On Fri, Oct 05, 2012 at 03:55:40AM +0200, Michael Hanselmann wrote: > This makes differences show up in “gnt-cluster verify”. > --- > lib/cmdlib.py | 18 ++++++++++++++---- > 1 files changed, 14 insertions(+), 4 deletions(-)
LGTM, one comment: > + # This one file should never ever be re-distributed via RPC > + assert not (redist and > + pathutils.FILE_STORAGE_PATHS_FILE in all_files_set) Maybe we should add an explicit assert in backend? In _BuildUploadFileList(), more precisely. thanks, iustin
