On Wed, Oct 17, 2012 at 01:09:55PM +0200, Iustin Pop wrote: > On Wed, Oct 17, 2012 at 12:12:26PM +0200, Michael Hanselmann wrote: > > 2012/10/16 Iustin Pop <[email protected]>: > > > On Tue, Oct 16, 2012 at 05:36:40PM +0200, Michael Hanselmann wrote: > > >> 2012/10/16 Iustin Pop <[email protected]>: > > >> > On Fri, Oct 05, 2012 at 03:55:43AM +0200, Michael Hanselmann wrote: > > >> >> When file storage is used this file is now mandatory. > > >> > > > >> > Not convinced about the 0644 mode for the file, but LGTM. > > >> > > >> I chose it as cfgupgrade has no concept of owners/groups, and > > >> ensure-dirs doesn't touch files in /etc. It seemed a safe choice. Do > > >> you agree? > > > > > > It's less about owners/groups, but rather wrr versus w--. I'm OK with > > > it, but I personally would have gone for a 0600. > > > > I just realized this file is only read by the node daemon, not by the > > master daemon. I'll change it to 0600. LGTY? > > Yes, of course, that's what I meant :)
Just in case this was not clear: this is an LGTM. iustin
