2012/10/10 Iustin Pop <[email protected]>: > On Wed, Oct 10, 2012 at 11:54:48AM +0200, Michael Hanselmann wrote: >> 2012/10/5 Iustin Pop <[email protected]>: >> > --- a/htools/Ganeti/Query/Query.hs >> > +++ b/htools/Ganeti/Query/Query.hs >> > @@ -103,7 +103,9 @@ maybeCollectLiveData False _ nodes = >> > >> > maybeCollectLiveData True cfg nodes = do >> > let vgs = [clusterVolumeGroupName $ configCluster cfg] >> > - hvs = clusterEnabledHypervisors $ configCluster cfg >> > + hvs = case clusterEnabledHypervisors $ configCluster cfg of >> > + [] -> [XenPvm] -- this case shouldn't happen, but we >> > handle it >> >> Why do you hardcode XenPvm here? Shouldn't you rather raise an >> exception or have this in a global place? > > Eee, I was thinking exactly about moving this into a > getDefaultHypervisor function in Config.hs, but then though "if I send > an interdiff, I will delay review even more". > > Thanks for catching this; interdiff:
LGTM
