Re: [PATCH master] Check minimum size of networks on creation

[Michael Hanselmann]

2013/1/21 Helga Velroyen <hel...@google.com>:
> --- a/lib/network.py
> +++ b/lib/network.py
>      self.network = ipaddr.IPNetwork(self.net.network)
> +    if self.network.numhosts < 4:

Please put this magic number into a constant at module level (so still
within network.py).

> +      raise errors.AddressPoolError(
> +        "A network of size %s is too small. Please specify at least a "
> +        "/30 network." % str(self.network.numhosts))

Wrong wrapping, see style guide.

Michael