On 21 January 2013 18:37, Michael Hanselmann <[email protected]> wrote: > 2013/1/21 Helga Velroyen <[email protected]>: >> --- a/lib/network.py >> +++ b/lib/network.py >> self.network = ipaddr.IPNetwork(self.net.network) >> + if self.network.numhosts < NETWORK_SIZE_MIN: >> + raise errors.AddressPoolError("A network of size %s is too small. >> Please " >> + "specify at least a /30 network." % >> + str(self.network.numhosts)) > > Now move the space at the end of the first line to the second and > remove punctuation, then LGTM. > > errors.AddressPoolError("A network of size %s is too small, specify" > " at least a /30 network" % > str(self.network.numhosts))
This is not very good. The "/30" should depend on the definition of NETWORK_SIZE_MIN (or maybe it's easier to do the opposite). Bernardo
