Re: [PATCH master 04/11] hv_xen: Test errors while writing config file

[Helga Velroyen]

LGTM, thanks


On Thu, Jan 24, 2013 at 5:24 PM, Michael Hanselmann <han...@google.com>wrote:

> Test error handling while writing Xen configuration files.
> ---
>  test/py/ganeti.hypervisor.hv_xen_unittest.py | 26
> ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/test/py/ganeti.hypervisor.hv_xen_unittest.py b/test/py/
> ganeti.hypervisor.hv_xen_unittest.py
> index 67dc785..fd05933 100755
> --- a/test/py/ganeti.hypervisor.hv_xen_unittest.py
> +++ b/test/py/ganeti.hypervisor.hv_xen_unittest.py
> @@ -23,6 +23,8 @@
>
>  import string # pylint: disable=W0402
>  import unittest
> +import tempfile
> +import shutil
>
>  from ganeti import constants
>  from ganeti import objects
> @@ -298,5 +300,29 @@ class
> TestXenHypervisorUnknownCommand(unittest.TestCase):
>      self.assertRaises(errors.ProgrammerError, hv._RunXen, [])
>
>
> +class TestXenHypervisorWriteConfigFile(unittest.TestCase):
> +  def setUp(self):
> +    self.tmpdir = tempfile.mkdtemp()
> +
> +  def tearDown(self):
> +    shutil.rmtree(self.tmpdir)
> +
> +  def testWriteError(self):
> +    cfgdir = utils.PathJoin(self.tmpdir, "foobar")
> +
> +    hv = hv_xen.XenHypervisor(_cfgdir=cfgdir,
> +                              _run_cmd_fn=NotImplemented,
> +                              _cmd=NotImplemented)
> +
> +    self.assertFalse(os.path.exists(cfgdir))
> +
> +    try:
> +      hv._WriteConfigFile("name", "data")
> +    except errors.HypervisorError, err:
> +      self.assertTrue(str(err).startswith("Cannot write Xen instance"))
> +    else:
> +      self.fail("Exception was not raised")
> +
> +
>  if __name__ == "__main__":
>    testutils.GanetiTestProgram()
> --
> 1.8.1
>
>

--