Re: [PATCH master 07/11] hv_xen: Test verifying hypervisor

[Helga Velroyen]

LGTM, thanks


On Thu, Jan 24, 2013 at 5:24 PM, Michael Hanselmann <han...@google.com>wrote:

> Test success and failure.
> ---
>  test/py/ganeti.hypervisor.hv_xen_unittest.py | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/test/py/ganeti.hypervisor.hv_xen_unittest.py b/test/py/
> ganeti.hypervisor.hv_xen_unittest.py
> index 61c7085..134182d 100755
> --- a/test/py/ganeti.hypervisor.hv_xen_unittest.py
> +++ b/test/py/ganeti.hypervisor.hv_xen_unittest.py
> @@ -383,6 +383,16 @@ class _TestXenHypervisor(object):
>      self.assertFalse(os.path.exists(autocfgfile))
>      self.assertEqual(utils.ReadFile(cfgfile), "content")
>
> +  def testVerify(self):
> +    output = testutils.ReadTestData("xen-xm-info-4.0.1.txt")
> +    hv = self._GetHv(run_cmd=compat.partial(self._SuccessCommand,
> +                                            output))
> +    self.assertTrue(hv.Verify() is None)
> +
> +  def testVerifyFailing(self):
> +    hv = self._GetHv(run_cmd=self._FailingCommand)
> +    self.assertTrue("failed:" in hv.Verify())
> +
>
>  def _MakeTestClass(cls, cmd):
>    """Makes a class for testing.
> --
> 1.8.1
>
>

--