On Thu, Jan 24, 2013 at 19:31 +0100, Iustin Pop <[email protected]> wrote: > > +module Ganeti.HTools.Program.Harep > > + (main
> please use "( main" (more idiomatic way of aligning the start of export > list. Oops, absolutely: --- src/Ganeti/HTools/Program/Harep.hs +++ src/Ganeti/HTools/Program/Harep.hs @@ -24,7 +24,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA -} module Ganeti.HTools.Program.Harep - (main + ( main , arguments , options) where > > + let lsock = optLuxi opts > > + > > + when (isNothing lsock) $ > > + exitErr "Luxi socket (-L) required to execute jobs." > I haven't checked later patches to see how it looks, but if this is > required, should be make a variant of oLuxiSocket that is enabled by > default? Or will there be cases where you can run this tool without > luxi? Ah. Yes, my initial plan was to give support for running without Luxi. But (see my comments in the cover message) that resulted in somewhat hairy code, so I decided against it. I'll send a 4.5/11 patch on Monday to add such variant of oLuxiSocket if that's ok with you. Thanks, -- Dato Simó | [email protected] Corp Fleet Management / Ganeti SRE (Dublin)
