Hi! thanks for the reviews.
On Tue, Jan 29, 2013 at 11:27 AM, Iustin Pop <[email protected]> wrote: > On Mon, Jan 28, 2013 at 06:05:41PM +0100, Helga Velroyen wrote: > > According to doc/design-network.rst, there is a new NIC > > parameter 'network', which can be used to link an instance > > to a network. This was so far undocumented in the man > > page of 'gnt-instance'. > > > > Signed-off-by: Helga Velroyen <[email protected]> > > --- > > man/gnt-instance.rst | 12 ++++++++---- > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > diff --git a/man/gnt-instance.rst b/man/gnt-instance.rst > > index 553bdcd..cf01b2a 100644 > > --- a/man/gnt-instance.rst > > +++ b/man/gnt-instance.rst > > @@ -114,6 +114,10 @@ link > > details). Note that openvswitch support is also hypervisor > > dependent. > > > > +network > > + derives the mode and the link from the settings of the network > > + which is identified by its name. > > + > > FYI, when network is set, some of the other options are disallowed (if I > understood the code correctly during the review); e.g. you can't set > mode/ip or so. So you might want to add that to the man page as well. > Actually, you can set an IP, but not link and mode. I added that to the patch and pushed it. Cheers, Helga -- You received this message because you are subscribed to the Google Groups "ganeti-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
