On Thu, Jan 31, 2013 at 01:07:31AM +0100, Bernardo Dal Seno wrote: > On 30 January 2013 18:20, Michael Hanselmann <han...@google.com> wrote: > > 2013/1/30 Bernardo Dal Seno <bdals...@google.com>: > >> +def TestExclStorSharedPv(node): > >> + AssertCommand(["lvcreate", "-L1G", "-nqa-vol0", "xenvg"], > >> node=node_name) > > > > Please don't use hardcoded names. Either make them at least constants > > or even configurable. That said: > > Ok, see interdiff below. > > > qa_cluster.py: (False, ["lvcreate", "-L1G", "-nqa-test", "xenvg"]), > > > > Please fix, too. :-) > > This is patch 5.5/17. > > > Interdiff:
LGTM, thanks. iustin
