On Fri, May 10, 2013 at 02:57:19PM +0200, Michele Tartara wrote: > Add the Xen instance status data collector with only its core features. > The next commits will add more reporting functionalities. > > The access to the collector is made possible through the mon-collector > tool. > > Signed-off-by: Michele Tartara <[email protected]> > --- > Makefile.am | 2 + > src/Ganeti/DataCollectors/InstStatus.hs | 111 > +++++++++++++++++++++++++++ > src/Ganeti/DataCollectors/InstStatusTypes.hs | 43 +++++++++++ > src/Ganeti/DataCollectors/Program.hs | 9 ++- > 4 files changed, 163 insertions(+), 2 deletions(-) > create mode 100644 src/Ganeti/DataCollectors/InstStatus.hs > create mode 100644 src/Ganeti/DataCollectors/InstStatusTypes.hs
> [...] > +-- | Get the list of instances ([primary], [secondary]) on the given node. > +-- Implemented as a function, even if used a single time, to specify in a In my opinion, there is no need to justify moving a well-defined computation into a separate function. But your choice. > +-- convenient and elegant way the return data type, required in order to > +-- prevent incurring in the monomorphism restriction. > +-- The server address and the server port parameters are mainly intended > +-- for testing purposes. If they are Nothing, the default values will be > used. > +getInstances > + :: String > + -> Maybe String > + -> Maybe Int > + -> IO (BT.Result ([Ganeti.Objects.Instance], [Ganeti.Objects.Instance])) > [...] LGTM. Thanks. -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Katherine Stephens
