On Fri, May 10, 2013 at 02:57:24PM +0200, Michele Tartara wrote:
> Instead of building the report as part of the "Main" function, have it
> built by its own dedicated function, so that it will be able to export it
> directly to the monitoring daemon when needed.
> 
> Signed-off-by: Michele Tartara <[email protected]>
> ---
>  src/Ganeti/DataCollectors/InstStatus.hs | 23 +++++++++++++++--------
>  1 file changed, 15 insertions(+), 8 deletions(-)
> 
> diff --git a/src/Ganeti/DataCollectors/InstStatus.hs 
> b/src/Ganeti/DataCollectors/InstStatus.hs
> index f3a8c1c..ecde3a2 100644
> --- a/src/Ganeti/DataCollectors/InstStatus.hs
> +++ b/src/Ganeti/DataCollectors/InstStatus.hs
> @@ -38,7 +38,7 @@ module Ganeti.DataCollectors.InstStatus
>  import Control.Exception.Base
>  import Data.Maybe
>  import qualified Data.Map as Map
> -import Network.BSD (getHostName)
> +import Network.BSD

In which way is this change of import related to the rest of this patch?
Or did I miss the additional function from that module that is now used.

Rest LGTM. Thanks.

-- 
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Graham Law, Katherine Stephens

Reply via email to