LGTM, Thanks
Guido On 10 May 2013 19:04, "Michele Tartara" <[email protected]> wrote: > On Fri, May 10, 2013 at 4:11 PM, Michele Tartara <[email protected]>wrote: > >> On Fri, May 10, 2013 at 3:57 PM, Klaus Aehlig <[email protected]> wrote: >> >>> > It's already there, automatically added as a dependency of some other >>> > package. >>> > Should I explicitly add it to the list? >>> >>> Yes, I would apreciate it. >>> >>> In my opinion, the INSTALL instructions and and the build_chroot should >>> be kept in sync. For the same reason we mention it in INSTALL and check >>> at configure, we should also add it explicitly there. I.e., we want to >>> document that we use it explicitly, and not just indirectly as a >>> dependency. >>> >> >> Yes, that's the reason why I added it to INSTALL, but I hadn't thought >> about adding it to the chroot builder as well. Good suggestion, I'll do it. >> >> > Interdiff: > diff --git a/devel/build_chroot b/devel/build_chroot > index d14f59e..0d04afd 100755 > --- a/devel/build_chroot > +++ b/devel/build_chroot > @@ -123,7 +123,9 @@ in_chroot -- \ > MonadCatchIO-transformers==0.2.2.0 mtl==2.0.1.0 \ > hashable==1.1.2.0 case-insensitive==0.3 parsec==3.0.1 \ > network==2.3 snap-server==0.8.1 \ > - hinotify==0.3.2 > + hinotify==0.3.2 \ > + process==1.0.1.2 > + > > #Python development tools > in_chroot -- \ > > > Thanks > Michele > >
