On 16 May 2013 10:23, Thomas Thrainer <[email protected]> wrote: > Split instance.py further by extracting storage related logical units > and functions to instance_storage.py. > > Signed-off-by: Thomas Thrainer <[email protected]> > --- > Makefile.am | 1 + > lib/cmdlib/__init__.py | 3 +- > lib/cmdlib/backup.py | 5 +- > lib/cmdlib/instance.py | 2391 +---------------------------------- > lib/cmdlib/instance_storage.py | 2462 > +++++++++++++++++++++++++++++++++++++ > lib/cmdlib/instance_utils.py | 274 ++--- > test/py/ganeti.cmdlib_unittest.py | 27 +- > 7 files changed, 2623 insertions(+), 2540 deletions(-) > create mode 100644 lib/cmdlib/instance_storage.py
Please add "cmdlib" to the patch title, so the context is more clear (we have enough character left, right?). I wonder if the ext_storage LUs/functions should be moved into instance_storage.py too. Rest LGTM, thanks Bernardo
