On 17 May 2013 09:49, Thomas Thrainer <[email protected]> wrote: > > On Thu, May 16, 2013 at 7:50 PM, Bernardo Dal Seno <[email protected]> > wrote: >> >> On 16 May 2013 10:23, Thomas Thrainer <[email protected]> wrote: >> > Split instance.py further by extracting storage related logical units >> > and functions to instance_storage.py. >> > >> > Signed-off-by: Thomas Thrainer <[email protected]> >> > --- >> > Makefile.am | 1 + >> > lib/cmdlib/__init__.py | 3 +- >> > lib/cmdlib/backup.py | 5 +- >> > lib/cmdlib/instance.py | 2391 >> > +---------------------------------- >> > lib/cmdlib/instance_storage.py | 2462 >> > +++++++++++++++++++++++++++++++++++++ >> > lib/cmdlib/instance_utils.py | 274 ++--- >> > test/py/ganeti.cmdlib_unittest.py | 27 +- >> > 7 files changed, 2623 insertions(+), 2540 deletions(-) >> > create mode 100644 lib/cmdlib/instance_storage.py >> >> Please add "cmdlib" to the patch title, so the context is more clear >> (we have enough character left, right?). >> > > Reworded to: > > cmdlib: Extract storage related functionality > > Split instance.py further by extracting storage related logical units > and functions to instance_storage.py. > > Signed-off-by: Thomas Thrainer <[email protected]> > > >> >> I wonder if the ext_storage LUs/functions should be moved into >> instance_storage.py too. > > > Hmm, maybe. I didn't do it, because they didn't seem to relate to instances > (the LUInstance* pattern didn't match :-)). If we want to move them to > instance_storage.py, I'd prefer to do this after this series is through...
It's storage, but it's manipulated independently from instances. So I'm not sure. Anyway LGTM, and those LUs can be always moved later, if someone thinks so. Bernardo
