On 22 May 2013 12:44, Thomas Thrainer <[email protected]> wrote: > LGTM, Thanks. > > > On Mon, May 20, 2013 at 5:11 PM, Bernardo Dal Seno <[email protected]> > wrote: >> >> "gnt-instance add" and "gnt-instance recreate-disks" are tested giving the >> number of spindles, when supported. Also, QA for "gnt-instance >> recreate-disks" now covers the case where disks are resized. >> >> Signed-off-by: Bernardo Dal Seno <[email protected]>
Added one more (small) test. Interdiff: diff --git a/qa/qa_instance.py b/qa/qa_instance.py index 08e3626..1c828af 100644 --- a/qa/qa_instance.py +++ b/qa/qa_instance.py @@ -828,6 +828,10 @@ def TestRecreateDisks(instance, inodes, othernodes): AssertCommand(["gnt-instance", "stop", instance.name]) # Disks exist: this should fail _AssertRecreateDisks([], instance, fail=True, destroy=False) + # Unsupported spindles parameters: fail + if not qa_config.AreSpindlesSupported(): + _AssertRecreateDisks(["--disk=0:spindles=2"], instance, + fail=True, destroy=False) # Recreate disks in place _AssertRecreateDisks([], instance) # Move disks away Bernardo
