LGTM, Thanks

On Thu, May 23, 2013 at 3:08 PM, Bernardo Dal Seno <[email protected]>wrote:

> On 22 May 2013 17:39, Thomas Thrainer <[email protected]> wrote:
> > LGTM, Thanks.
> >
> >
> > On Wed, May 22, 2013 at 5:37 PM, Bernardo Dal Seno <[email protected]>
> > wrote:
> >>
> >> On 22 May 2013 12:44, Thomas Thrainer <[email protected]> wrote:
> >> > LGTM, Thanks.
> >> >
> >> >
> >> > On Mon, May 20, 2013 at 5:11 PM, Bernardo Dal Seno <
> [email protected]>
> >> > wrote:
> >> >>
> >> >> "gnt-instance add" and "gnt-instance recreate-disks" are tested
> giving
> >> >> the
> >> >> number of spindles, when supported. Also, QA for "gnt-instance
> >> >> recreate-disks" now covers the case where disks are resized.
> >> >>
> >> >> Signed-off-by: Bernardo Dal Seno <[email protected]>
> >>
>
> Last-minute addition, I forgot one new parameter in the QA sample
> configuration:
>
> diff --git a/qa/qa-sample.json b/qa/qa-sample.json
> index 55bf1b9..dbce716 100644
> --- a/qa/qa-sample.json
> +++ b/qa/qa-sample.json
> @@ -74,13 +74,15 @@
>        "size": "1G",
>        "spindles": 2,
>        "name": "disk0",
> -      "growth": "2G"
> +      "growth": "2G",
> +      "spindles-growth": 1
>      },
>      {
>        "size": "512M",
>        "spindles": 1,
>        "name": "disk1",
> -      "growth": "768M"
> +      "growth": "768M",
> +      "spindles-growth": 0
>      }
>    ],
>
> Bernardo
>



-- 
Thomas Thrainer | Software Engineer | [email protected] |

Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Katherine Stephens

Reply via email to