On Thu, Jul 11, 2013 at 2:11 PM, Klaus Aehlig <[email protected]> wrote:

> At debug level, we can well afford to have a detailed entry
> for each message received by a server.
>
> Signed-off-by: Klaus Aehlig <[email protected]>
> ---
>  src/Ganeti/Query/Server.hs | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/Ganeti/Query/Server.hs b/src/Ganeti/Query/Server.hs
> index 3c8d8a9..49e79cd 100644
> --- a/src/Ganeti/Query/Server.hs
> +++ b/src/Ganeti/Query/Server.hs
> @@ -203,6 +203,7 @@ handleClientMsg client creader args = do
>  handleClient :: Client -> ConfigReader -> IO Bool
>  handleClient client creader = do
>    !msg <- recvMsgExt client
> +  logDebug $ "Received message: " ++ take 2000 (show msg)
>

As suggested before, I think we should print the enitre message.


>    case msg of
>      RecvConnClosed -> logDebug "Connection closed" >> return False
>      RecvError err -> logWarning ("Error during message receiving: " ++
> err) >>
> --
> 1.8.3
>
>
With that, LGTM

Reply via email to