(still) lgtm On Jul 12, 2013 3:42 PM, "Klaus Aehlig" <[email protected]> wrote:
> On Fri, Jul 12, 2013 at 03:05:22PM +0200, Helga Velroyen wrote: > > On Thu, Jul 11, 2013 at 2:11 PM, Klaus Aehlig <[email protected]> wrote: > > > > > At debug level, we can well afford to have a detailed entry > > > for each message received by a server. > > > > > > Signed-off-by: Klaus Aehlig <[email protected]> > > > --- > > > src/Ganeti/Query/Server.hs | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/src/Ganeti/Query/Server.hs b/src/Ganeti/Query/Server.hs > > > index 3c8d8a9..49e79cd 100644 > > > --- a/src/Ganeti/Query/Server.hs > > > +++ b/src/Ganeti/Query/Server.hs > > > @@ -203,6 +203,7 @@ handleClientMsg client creader args = do > > > handleClient :: Client -> ConfigReader -> IO Bool > > > handleClient client creader = do > > > !msg <- recvMsgExt client > > > + logDebug $ "Received message: " ++ take 2000 (show msg) > > > > > > > As suggested before, I think we should print the enitre message. > > > > > > > case msg of > > > RecvConnClosed -> logDebug "Connection closed" >> return False > > > RecvError err -> logWarning ("Error during message receiving: " ++ > > > err) >> > > > -- > > > 1.8.3 > > > > > > > > With that, LGTM > > FYI. Interdiff. > > diff --git a/src/Ganeti/Query/Server.hs b/src/Ganeti/Query/Server.hs > index 6f6cdee..46e70cc 100644 > --- a/src/Ganeti/Query/Server.hs > +++ b/src/Ganeti/Query/Server.hs > @@ -207,7 +207,7 @@ handleClientMsg client creader args = do > handleClient :: Client -> ConfigReader -> IO Bool > handleClient client creader = do > !msg <- recvMsgExt client > - logDebug $ "Received message: " ++ take 2000 (show msg) > + logDebug $ "Received message: " ++ show msg > case msg of > RecvConnClosed -> logDebug "Connection closed" >> return False > RecvError err -> logWarning ("Error during message receiving: " ++ > err) >> > > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Katherine Stephens >
