On Wed, Oct 16, 2013 at 11:17 AM, Apollon Oikonomopoulos <[email protected]> wrote: > Luxid was not handled in start_master() and stop_master() at all. As a result, > during a master-failover, luxid would be left running on the old master and > would not start on the new master, leaving the cluster without management > until > luxid was manually started. > > Signed-off-by: Apollon Oikonomopoulos <[email protected]> > --- > daemons/daemon-util.in | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/daemons/daemon-util.in b/daemons/daemon-util.in > index 44c39a9..f1e5941 100644 > --- a/daemons/daemon-util.in > +++ b/daemons/daemon-util.in > @@ -292,12 +292,14 @@ check_and_start() { > start_master() { > start ganeti-masterd > start ganeti-rapi > + _confd_enabled && start ganeti-luxid > } > > # Stops the master role > stop_master() { > stop ganeti-rapi > stop ganeti-masterd > + _confd_enabled && stop ganeti-luxid
Hi Apollon, thanks for this patch. I think, though, that both this line and the corresponding on in start_master() should not be conditional on _confd_enabled: confd is optional, but luxid is not, as you noticed (without luxid, some things don't work). And they used to be part of the same executable, but since 2.8 they are two different daemons, running in different places (only master for luxid, all the master candidates for confd). > } > > # Start all daemons > -- > 1.7.10.4 > Thanks, Michele -- Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
