On Wed, Oct 16, 2013 at 1:29 PM, Apollon Oikonomopoulos <[email protected]> wrote: > On 14:14 Wed 16 Oct , Apollon Oikonomopoulos wrote: >> I included _confd_enabled because it is still used throught >> daemon-util. In particular, the DAEMONS array is populated based on >> this check. Also, the code in start() causes a failure if luxid or >> confd are referred to but _confd_enabled returns false. >> >> IOW, I know the daemons are mandatory, but then the whole _confd_enabled >> check should be removed from daemon-util, which is a different patch. >> Until then, the check is consistent with the rest of the code :-). >> >> Apollon > > Hmm, configure's enable-split-query support still checks for confd > support. From configure.ac: > > if test x$enable_split_query = xTrue -a x$has_confd != xTrue; then > AC_MSG_ERROR([Split queries require the confd daemon]) > fi > > And the Makefile also ships luxid only if ENABLE_CONFD is set. Are we > sure luxid is mandatory? > > Apollon
Sorry, I was a little bit too forward thinking. :-) I replied out of the top of my head, but what I stated was not the situation as of 2.8, but the expected one soon enough. LuxiD will indeed be a required part of the system (it will take over many functionalities from master) but as of 2.8 it is just half of the old ConfD, and it is not mandatory: it is still controlled by the same "enabled" variable as confd. So, LGTM to the patch as it is, and thanks a lot. Cheers, Michele -- Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
