On Fri, Nov 8, 2013 at 5:42 PM, Klaus Aehlig <[email protected]> wrote: >> Rest LGTM, no need to resend. > > Unfortunately, the client has to be closed here as well > > Interdiff 19/22 Make luxid handle SubmitJob > > diff --git a/src/Ganeti/Query/Server.hs b/src/Ganeti/Query/Server.hs > index dead59a..d16da03 100644 > --- a/src/Ganeti/Query/Server.hs > +++ b/src/Ganeti/Query/Server.hs > @@ -208,6 +208,7 @@ handleCall qlock cfg (SubmitJobToDrainedQueue ops) = > socketpath <- defaultLuxiSocket > client <- getClient socketpath > pickupResult <- callMethod (PickupJob jid) client > + closeClient client > case pickupResult of > Ok _ -> return () > Bad e -> logWarning $ "Failded to notify masterd: " ++ show e > > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
Right, I hadn't noticed this one. LGTM, thanks. Michele -- Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
