On Mon, Jun 16, 2014 at 02:05:14PM +0300, Dimitris Aragiorgis wrote: > A network is currently connected to a nodegroup with a mode and a > link. Those netparams are inherited as nicparams when a NIC is > attached to a network and filled with the cluster wide defaults. > > Since vlan was added to NIC parameters, netparams should be updated > to include it too otherwise NICs attached to a network can be found > with mode=bridged, link=some bridge and the cluster wide vlan. > > This patch fixes LUNetworkConnect to add an empty string vlan to > netparams along with the user provided mode and link. Additionally > it adds an empty vlan to existing netparams via > objects.NodeGroup.UpgradeConfig(). > > Signed-off-by: Dimitris Aragiorgis <[email protected]> > --- > lib/cmdlib/network.py | 3 +++ > lib/objects.py | 3 +++ > 2 files changed, 6 insertions(+)
LGTM -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
