On Mon, Jun 16, 2014 at 02:05:17PM +0300, Dimitris Aragiorgis wrote: > Until now gnt-network connect expected the network, > mode, link, and optionally groups as positional arguments. > > To be able to pass vlan info too, use the `--nic-parameters` > option, just like gnt-cluster client to pass the desired > mode, link, and vlan. Missing values will be filled with the > default ones. > > Do not support old argument passing since mode and link should > be arguments with variable length and this violates bash completion > generation rules. > > Update QA to pass the new option instead of deprecated arguments. > > Signed-off-by: Dimitris Aragiorgis <[email protected]> > --- > lib/client/gnt_network.py | 16 +++++++++------- > lib/cmdlib/network.py | 2 +- > lib/rapi/client.py | 5 +++-- > man/gnt-network.rst | 10 +++++++--- > qa/qa_network.py | 5 ++++- > src/Ganeti/OpCodes.hs | 1 + > src/Ganeti/OpParams.hs | 6 ++++++ > test/hs/Test/Ganeti/OpCodes.hs | 2 +- > 8 files changed, 32 insertions(+), 15 deletions(-)
LGTM -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
