OK, at the end there is a patch that tests something, but not all. I'll update it to test everything.
On Fri, Jul 4, 2014 at 2:07 PM, Klaus Aehlig <[email protected]> wrote: > On Fri, Jul 04, 2014 at 01:17:58PM +0200, 'Petr Pudlak' via ganeti-devel > wrote: > > .. so that they can be persisted. > > > > Signed-off-by: Petr Pudlak <[email protected]> > > --- > > src/Ganeti/Utils/MultiMap.hs | 5 +++++ > > src/Ganeti/WConfd/TempRes.hs | 19 ++++++++++++------- > > 2 files changed, 17 insertions(+), 7 deletions(-) > > In general, looks good. However, whenever adding a new JSON instance, > please also add a test that readJSON . showJSON = Ok. That can go into > a separate patch, but should be part of the same patch series. > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >
