I'll keep 'generate' in this patch and I'll send a follow-up patch that
removes it that will follow just this one.


On Fri, Jul 4, 2014 at 3:21 PM, Petr Pudlák <[email protected]> wrote:

> OK, I'll make it into a separate patch.
>
>
> On Fri, Jul 4, 2014 at 3:11 PM, Klaus Aehlig <[email protected]> wrote:
>
>> On Fri, Jul 04, 2014 at 01:18:05PM +0200, 'Petr Pudlak' via ganeti-devel
>> wrote:
>> > Before many of them threw just GenericError.
>> >
>> > Signed-off-by: Petr Pudlak <[email protected]>
>> > ---
>> >  src/Ganeti/WConfd/TempRes.hs | 28 ++++++++++++++++------------
>> >  1 file changed, 16 insertions(+), 12 deletions(-)
>> >
>> > diff --git a/src/Ganeti/WConfd/TempRes.hs b/src/Ganeti/WConfd/TempRes.hs
>> > index effde60..145ca9b 100644
>> > --- a/src/Ganeti/WConfd/TempRes.hs
>> > +++ b/src/Ganeti/WConfd/TempRes.hs
>> > @@ -48,7 +48,6 @@ module Ganeti.WConfd.TempRes
>> >    , reserve
>> >    , dropReservationsFor
>> >    , reserved
>> > -  , generate
>>
>> While, in general, it is OK to hide functions not needed outside a module,
>> I cannot see the connection to throwing a different error.
>>
>> --
>> Klaus Aehlig
>> Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
>> Registergericht und -nummer: Hamburg, HRB 86891
>> Sitz der Gesellschaft: Hamburg
>> Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
>>
>
>

Reply via email to