On Tue, Oct 7, 2014 at 11:04 AM, 'Klaus Aehlig' via ganeti-devel <
ganeti-devel@googlegroups.com> wrote:
> ....to decide if a migration is safe.
>
> Signed-off-by: Klaus Aehlig <aeh...@google.com>
> ---
> lib/cmdlib/instance_migration.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/cmdlib/instance_migration.py
> b/lib/cmdlib/instance_migration.py
> index 164f3b5..56a6f53 100644
> --- a/lib/cmdlib/instance_migration.py
> +++ b/lib/cmdlib/instance_migration.py
> @@ -36,6 +36,7 @@ import time
> from ganeti import constants
> from ganeti import errors
> from ganeti import locking
> +from ganeti import hypervisor
> from ganeti.masterd import iallocator
> from ganeti import utils
> from ganeti.cmdlib.base import LogicalUnit, Tasklet
> @@ -698,7 +699,8 @@ class TLMigrateInstance(Tasklet):
> self.feedback_fn("* warning: hypervisor version mismatch between"
> " source (%s) and target (%s) node" %
> (src_version, dst_version))
> - if utils.HVVersionsLikelySafeForMigration(src_version,
> dst_version):
> + hv = hypervisor.GetHypervisor(self.instance.hypervisor)
> + if hv.VersionsSafeForMigration(src_version, dst_version):
> self.feedback_fn(" migrating from hypervisor version %s to %s
> should"
> " be safe" % (src_version, dst_version))
> else:
> --
> 2.1.0.rc2.206.gedb03e5
>
>
LGTM, thanks
--
Helga Velroyen | Software Engineer | hel...@google.com |
Google Germany GmbH
Dienerstr. 12
80331 München
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores
