On Tue, Oct 7, 2014 at 11:04 AM, 'Klaus Aehlig' via ganeti-devel <
ganeti-devel@googlegroups.com> wrote:

> Already in Ganeti 2.8, the machine_version feature was added to
> the kvm hypervisor which allows migration in most cases. In order
> not to block legitimate use cases, restore the old behavior and
> do not check for version on kvm.
>
> Signed-off-by: Klaus Aehlig <aeh...@google.com>
> ---
>  lib/hypervisor/hv_kvm/__init__.py | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/lib/hypervisor/hv_kvm/__init__.py
> b/lib/hypervisor/hv_kvm/__init__.py
> index 2c946af..747faf1 100644
> --- a/lib/hypervisor/hv_kvm/__init__.py
> +++ b/lib/hypervisor/hv_kvm/__init__.py
> @@ -499,6 +499,16 @@ class KVMHypervisor(hv_base.BaseHypervisor):
>      dirs = [(dname, constants.RUN_DIRS_MODE) for dname in self._DIRS]
>      utils.EnsureDirs(dirs)
>
> +  @staticmethod
> +  def VersionsSafeForMigration(src, target):
> +    """Predict if migration is safe between those versions
> +
> +    """
> +    # Actually, it is not that easy. However, with the kvm machine_version
> +    # feature, migration suceeds in most cases. So we try not to block
> +    # legitimate migrations.
> +    return True
> +
>    @classmethod
>    def _InstancePidFile(cls, instance_name):
>      """Returns the instance pidfile.
> --
> 2.1.0.rc2.206.gedb03e5
>
>
LGTM, thanks

-- 
Helga Velroyen | Software Engineer | hel...@google.com |

Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Reply via email to