LGTM On Tue, Nov 18, 2014 at 3:41 PM, 'Klaus Aehlig' via ganeti-devel < [email protected]> wrote:
> For most jobs submitted by the watcher, it identifies > itself correctly in the reason trail. However, one > instance of an OpInstanceActivateDisk job was missed. > Fix this. > > Signed-off-by: Klaus Aehlig <[email protected]> > --- > lib/watcher/__init__.py | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/lib/watcher/__init__.py b/lib/watcher/__init__.py > index 605a453..ceb8f88 100644 > --- a/lib/watcher/__init__.py > +++ b/lib/watcher/__init__.py > @@ -384,7 +384,11 @@ def _VerifyDisks(cl, uuid, nodes, instances): > " or has offline secondaries", name) > continue > > - job.append(opcodes.OpInstanceActivateDisks(instance_name=name)) > + op = opcodes.OpInstanceActivateDisks(instance_name=name) > + op.reason = [(constants.OPCODE_REASON_SRC_WATCHER, > + "Activating disks for instance %s" % name, > + utils.EpochNano())] > + job.append(op) > > if job: > job_id = cli.SendJob(job, cl=cl) > -- > 2.1.0.rc2.206.gedb03e5 > >
