On Mon, Nov 17, 2014 at 7:56 PM, 'Aaron Karper' via ganeti-devel <[email protected]> wrote: > Signed-off-by: Aaron Karper <[email protected]> > --- > lib/config/__init__.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/config/__init__.py b/lib/config/__init__.py > index 6e7f0fb..a8a0f79 100644 > --- a/lib/config/__init__.py > +++ b/lib/config/__init__.py > @@ -3451,6 +3451,8 @@ class ConfigWriter(object): > > > class DetachedConfig(ConfigWriter): > + """Read-only snapshot of the config.""" > + > def __init__(self, config_data): > super(DetachedConfig, self).__init__(self, offline=True) > self._SetConfigData(config_data) > -- > 2.1.0.rc2.206.gedb03e5 >
Provided that pylint is fine with having 1-line docstrings being written like that, LGTM. Otherwise rewrite it as: """Read-only snapshot of the config. """ Thanks, Michele. -- Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
