On Mon, Nov 17, 2014 at 7:56 PM, 'Aaron Karper' via ganeti-devel <[email protected]> wrote: > This comment should show lines along which the ConfigWriter class can be > split. > > Signed-off-by: Aaron Karper <[email protected]> > --- > lib/config/__init__.py | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/lib/config/__init__.py b/lib/config/__init__.py > index a8a0f79..62babaa 100644 > --- a/lib/config/__init__.py > +++ b/lib/config/__init__.py > @@ -172,6 +172,11 @@ class ConfigWriter(object): > > @ivar _all_rms: a list of all temporary reservation managers > > + Currently the class fulfills 3 main functions: > + 1. lock the configuration for access (monitor) > + 2. reload and write the config if necessary (bridge) > + 3. provide convenient access methods to config data (facade) > + > """ > def __init__(self, cfg_file=None, offline=False, _getents=runtime.GetEnts, > accept_foreign=False, wconfdcontext=None, wconfd=None): > -- > 2.1.0.rc2.206.gedb03e5 >
LGTM, thanks. Cheers, Michele -- Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
