On Wed, Apr 15, 2015 at 01:47:37PM +0000, 'BSRK Aditya' via ganeti-devel wrote: > BSRK Aditya (9): > Add accessor functions to retrive a disk/instance > Port function to retrive LVs by Node > Port function to retrive all LVs > Port function to retrive all IDs > Port function to get all MACs > Port UUID config checks > Port checks for addInstance > Modify RPC addInstance to use checks > Remove config checks from AddInstance
On a more general level, moving checks that can as well be done on the client to WConfD is not a value in itself; WConfD is already quite busy and everything depends on it. That said, there are some checks that do make sense to have on the Daemon side, e.g., the ones you removed in the TODO (in patch 8). - Check that the caller actually owns a lock on the object it is modifying (hence justifying modification without asking for the config lock). - Check the presence or absence of the UUID as key in the map modified (not the general consisntency check about UUIDs actually generated uniquely). The value of those checks is detect errors in the calling pattern, e.g., issuing a call twice, or in wrong order. It is not the purpose of saving the client work at the cost of the already overly busy daemon. -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
