O Wed, Apr 15, 2015 at 04:35:08PM +0200, Klaus Aehlig wrote:
> > +
> > +getAllLVs :: ConfigState -> GenericResult GanetiException [String]
> 
> here as well: documentation of the function and why in GenericResult
> and not just returning [String]?
> 

All these functions are built on top on the preceeding functions.
The functions at the foundation are getDiskByUUID and getInstanceByUUID.

These two functions can theoriotically fail if we supply to them an
erroneuos UUID. Similarly, getInstanceLVsByNode' can also fail if we supply
a false instance UUID. Thus they are encapsulated under GenericResult.

getAllLVs and getAllIDs, however, takes no input except ConfigState.
But it still relies on the functions that preceed it. Hence it
is still encapsulated under GenericResult.

> -- 
> Klaus Aehlig
> Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
> Registergericht und -nummer: Hamburg, HRB 86891
> Sitz der Gesellschaft: Hamburg
> Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores

Reply via email to