Comment #6 on issue 1113 by [email protected]: ganeti-luxid fills the log storage with millions lines like "INFO Successfully handled WaitForJobChange"
https://code.google.com/p/ganeti/issues/detail?id=1113

commit 3f9f0ecf58dc817fc812efd83b477b9bb3a8e495
Author: Klaus Aehlig <[email protected]>
Date:   Mon Jun 29 11:34:13 2015 +0200

    Downgrade log-message for rereading job

    The fact that luxid is rereading a job file because it has
    changed on disk is mainly of internal interest for debugging.
    Hence downgrade the log-level accordingly.

    Signed-off-by: Klaus Aehlig <[email protected]>
    Reviewed-by: Petr Pudlak <[email protected]>

diff --git a/src/Ganeti/JQScheduler.hs b/src/Ganeti/JQScheduler.hs
index fcc6b8c..fbddaf7 100644
--- a/src/Ganeti/JQScheduler.hs
+++ b/src/Ganeti/JQScheduler.hs
@@ -132,7 +132,7 @@ readJobStatus jWS@(JobWithStat {jStat=fstat, jJob=job}) = do
       return Nothing
     Just fstat' -> do
       let jids = show $ fromJobId jid
-      logInfo $ "Rereading job "  ++ jids
+      logDebug $ "Rereading job "  ++ jids
       readResult <- loadJobFromDisk qdir True jid
       case readResult of
         Bad s -> do

commit 6a3bcc6b578a4286a0ce91a1b11f1500602fcdea
Author: Klaus Aehlig <[email protected]>
Date:   Mon Jun 29 11:30:13 2015 +0200

    Dowgrade log-level for successful requests

    Originally, only queries used the be served by haskell daemons
    over domain sockets. As they were not too frequent, it was OK
    to log each of them at INFO level. However, with requests as
    frequent as WaitForJobChange served via luxid, logs fill up
    to quickly. So log at debug level only.

    Signed-off-by: Klaus Aehlig <[email protected]>
    Reviewed-by: Petr Pudlak <[email protected]>

diff --git a/src/Ganeti/UDSServer.hs b/src/Ganeti/UDSServer.hs
index c5e0508..2d5c529 100644
--- a/src/Ganeti/UDSServer.hs
+++ b/src/Ganeti/UDSServer.hs
@@ -303,7 +303,7 @@ logMsg handler req (Bad err) =
 logMsg handler req (Ok result) = do
   -- only log the first 2,000 chars of the result
   logDebug $ "Result (truncated): " ++ take 2000 (J.encode result)
-  logInfo $ "Successfully handled " ++ hInputLogShort handler req
+  logDebug $ "Successfully handled " ++ hInputLogShort handler req

 -- | Prepares an outgoing message.
 prepareMsg


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

Reply via email to