On Thu, Jun 25, 2015 at 05:32:10PM +0200, 'Helga Velroyen' via ganeti-devel 
wrote:
> This patch makes prepare_node_join use some of the functions
> that were moved to tools/common.py. The respective unittests
> are removed, because they are already tested in
> common_unittest.py.
> 
> Signed-off-by: Helga Velroyen <[email protected]>
> ---
>  lib/tools/prepare_node_join.py                     | 41 ++---------------
>  test/py/ganeti.tools.common_unittest.py            | 53 
> ++++++++++++++++++++++
>  test/py/ganeti.tools.prepare_node_join_unittest.py | 48 --------------------
>  3 files changed, 57 insertions(+), 85 deletions(-)

LGTM

-- 
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores

Reply via email to