> @@ -2953,6 +2954,8 @@ class _RunWhileClusterStoppedHelper(object): > @param online_nodes: List of names of online nodes > @type ssh_ports: list > @param ssh_ports: List of SSH ports of online nodes > + @type exclude_daemons: list of string > + @param exclude_daemons: list of daemons to shutdown
The implementation (as well as the name *exclude*_daemons) suggest that these are the daemons that are allowed to continue running, not the ones to shutdown. Please fix documentation. > daemons :: FrozenSet String > daemons = > - ConstantUtils.mkSet [confd, > + ConstantUtils.mkSet [noded, > + wconfd, > + rapi, > luxid, > - masterd, > - mond, > - noded, > - rapi] > + kvmd, > + mond] How is this change related to this patch? -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
