On Tue, Jun 30, 2015 at 01:24:53PM +0000, Helga Velroyen wrote:
> Hi,
>
> I realized that simply squashing patch 29 won't work, as it partially
> belongs to patch 08 as well. Instead, consider this interdiff (I'll send
> another one for patch 08):
>
> diff --git a/lib/client/gnt_cluster.py b/lib/client/gnt_cluster.py
> index 5afbdda..54f0d35 100644
> --- a/lib/client/gnt_cluster.py
> +++ b/lib/client/gnt_cluster.py
> @@ -1090,7 +1090,8 @@ def _RenewCrypto(new_cluster_cert, new_rapi_cert, #
> pylint: disable=R0911
> RunWhileClusterStopped(ToStdout, _RenewCryptoInner)
>
> if new_node_cert:
> - RunWhileDaemonsStopped(ToStdout, [constants.WCONFD], _RenewClientCerts)
> + RunWhileDaemonsStopped(ToStdout, [constants.NODED, constants.WCONFD],
> + _RenewClientCerts)
>
> ToStdout("All requested certificates and keys have been replaced."
> " Running \"gnt-cluster verify\" now is recommended.")
LGTM for the patch with that interdiff
--
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
