> > This could be simplified to just 'toList' from Foldable. > FYI, interdiff
commit 1160d3db33a0293a2981c75bf825701f1850bfde Author: Klaus Aehlig <[email protected]> Date: Tue Aug 4 16:40:51 2015 +0200 Interdiff [PATCH stable-2.12 2/3] Add a function computing the filter arguments diff --git a/src/Ganeti/Query/Language.hs b/src/Ganeti/Query/Language.hs index 5a5f5aa..8144084 100644 --- a/src/Ganeti/Query/Language.hs +++ b/src/Ganeti/Query/Language.hs @@ -196,7 +196,7 @@ data Filter a -- to decide which additional fields to fetch in a query depending -- on live data. filterArguments :: Filter a -> [a] -filterArguments = fold . fmap return +filterArguments = toList -- | Serialiser for the 'Filter' data type. showFilter :: (JSON a) => Filter a -> JSValue > Rest LGTM, no need to resend. Thanks -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
