On Tue, Aug 04, 2015 at 04:49:10PM +0200, Klaus Aehlig wrote: > > > I'm not that familiar with this part of the code, so my (only) > > concern here is: are we sure that the `fields` argument passed to > > the function never contains duplicates? If we are, LGTM, if not, > > using `take count` later could return additional fields from the > > filter. > > That's a bit of an edge case: in no case such queries make sense, > so it is not specified what should happen in this case. > But let's play it safe: it is always OK to return each requested > field only once, so the following interdiff should solve the concern.
Sorry for remembering the semantics incorrectly. If a field is requested several times (which no one will ever do in real live, but we have a test for this), it is supposed to be returned twice. Will send a fix for this. -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
