Hi,

there is still one my review comment pending for the older patch series, so let's review this new one only after that is resolved.

  Thanks,
  Petr

On Thu, Sep 03, 2015 at 02:14:39PM +0200, 'Bhimanavajjula Aditya' via ganeti-devel wrote:
Bhimanavajjula Aditya (12):
 Add suffixes dyn_hi and dyn_o to cleanup list
 Allow higher versions of json and lens
 Make MonadPlus instance definitions depend on Alternative definitions
 Hide isSubsequenceOf when importing from Data.List
 Derive Generic when making ADTs using deriveADT
 Append a string when using newName on keywords
 Remove trailing spaces in field names
 Add signatures for some ambiguous types
 Use explicit forall quantification for types
 Reintroduce FromString, and replace Error with it
 Add a Functor instance of ResultT
 Create module Ganeti.Prelude and use it

Makefile.am                                     |   3 +
cabal/ganeti.template.cabal                     |   4 +-
src/Ganeti/BasicTypes.hs                        | 109 +++++++-----
src/Ganeti/Codec.hs                             |  14 +-
src/Ganeti/Confd/Server.hs                      |   4 +-
src/Ganeti/Confd/Types.hs                       |   2 +-
src/Ganeti/Confd/Utils.hs                       |   4 +-
src/Ganeti/Config.hs                            |   7 +-
src/Ganeti/ConstantUtils.hs                     |   4 +-
src/Ganeti/Cpu/LoadParser.hs                    |   5 +-
src/Ganeti/DataCollectors.hs                    |   4 +-
src/Ganeti/DataCollectors/XenCpuLoad.hs         |   5 +-
src/Ganeti/Errors.hs                            |   8 +-
src/Ganeti/HTools/Cluster.hs                    |  14 +-
src/Ganeti/HTools/Dedicated.hs                  |   5 +-
src/Ganeti/HTools/Node.hs                       |   6 +-
src/Ganeti/HTools/Types.hs                      |   9 +-
src/Ganeti/Hypervisor/Xen/XmParser.hs           |   4 +-
src/Ganeti/JQScheduler.hs                       |  21 ++-
src/Ganeti/JQueue.hs                            |  21 ++-
src/Ganeti/JSON.hs                              |  10 +-
src/Ganeti/Kvmd.hs                              |   6 +-
src/Ganeti/Lens.hs                              |   5 +-
src/Ganeti/Locking/Allocation.hs                |   7 +-
src/Ganeti/Locking/Locks.hs                     |   4 +-
src/Ganeti/Logging.hs                           |  14 +-
src/Ganeti/Luxi.hs                              |   2 +-
src/Ganeti/Metad/ConfigCore.hs                  |   4 +-
src/Ganeti/Monitoring/Server.hs                 |   6 +-
src/Ganeti/Network.hs                           |  28 +--
src/Ganeti/Objects.hs                           |   7 +-
src/Ganeti/Objects/BitArray.hs                  |   4 +-
src/Ganeti/Objects/Disk.hs                      |   4 +-
src/Ganeti/Objects/Instance.hs                  |   3 +-
src/Ganeti/Objects/Maintenance.hs               |   2 +-
src/Ganeti/OpCodes.hs                           |   4 +-
src/Ganeti/OpParams.hs                          |  10 +-
src/Ganeti/Parsers.hs                           |   4 +-
src/Ganeti/Prelude.hs                           | 218 ++++++++++++++++++++++++
src/Ganeti/Query/Exec.hs                        |  10 +-
src/Ganeti/Query/Filter.hs                      |  11 +-
src/Ganeti/Query/Language.hs                    |   7 +-
src/Ganeti/Query/Node.hs                        |   6 +-
src/Ganeti/Query/Server.hs                      |   6 +-
src/Ganeti/Rpc.hs                               |   2 +-
src/Ganeti/Runtime.hs                           |   3 +-
src/Ganeti/Ssconf.hs                            |   6 +-
src/Ganeti/Storage/Diskstats/Parser.hs          |   4 +-
src/Ganeti/Storage/Drbd/Parser.hs               |   5 +-
src/Ganeti/Storage/Lvm/LVParser.hs              |   4 +-
src/Ganeti/THH.hs                               |  45 +++--
src/Ganeti/THH/HsRPC.hs                         |  10 +-
src/Ganeti/THH/PyRPC.hs                         |   6 +-
src/Ganeti/THH/PyType.hs                        |   6 +-
src/Ganeti/THH/RPC.hs                           |  10 +-
src/Ganeti/Types.hs                             |   6 +-
src/Ganeti/UDSServer.hs                         |   6 +-
src/Ganeti/Utils.hs                             |  19 ++-
src/Ganeti/Utils/Atomic.hs                      |   6 +-
src/Ganeti/Utils/Livelock.hs                    |   4 +-
src/Ganeti/Utils/Monad.hs                       |   2 +-
src/Ganeti/Utils/MultiMap.hs                    |   4 +-
src/Ganeti/Utils/Random.hs                      |   4 +-
src/Ganeti/Utils/UniStd.hs                      |   2 +-
src/Ganeti/Utils/Validate.hs                    |  18 +-
src/Ganeti/WConfd/Client.hs                     |   2 +-
src/Ganeti/WConfd/ConfigModifications.hs        |   8 +-
src/Ganeti/WConfd/ConfigState.hs                |   4 +-
src/Ganeti/WConfd/ConfigVerify.hs               |   3 +-
src/Ganeti/WConfd/ConfigWriter.hs               |   8 +-
src/Ganeti/WConfd/Monad.hs                      |   5 +-
src/Ganeti/WConfd/Persistent.hs                 |   2 +-
src/Ganeti/WConfd/Server.hs                     |   5 +-
src/Ganeti/WConfd/TempRes.hs                    |   6 +-
test/hs/Test/Ganeti/BasicTypes.hs               |   4 +-
test/hs/Test/Ganeti/Confd/Types.hs              |   4 +-
test/hs/Test/Ganeti/HTools/Instance.hs          |   4 +-
test/hs/Test/Ganeti/HTools/Types.hs             |   4 +-
test/hs/Test/Ganeti/JQScheduler.hs              |   5 +-
test/hs/Test/Ganeti/JQueue/Objects.hs           |   4 +-
test/hs/Test/Ganeti/Locking/Allocation.hs       |   4 +-
test/hs/Test/Ganeti/Locking/Locks.hs            |   5 +-
test/hs/Test/Ganeti/Locking/Waiting.hs          |   5 +-
test/hs/Test/Ganeti/Luxi.hs                     |   4 +-
test/hs/Test/Ganeti/Objects.hs                  |   6 +-
test/hs/Test/Ganeti/OpCodes.hs                  |   6 +-
test/hs/Test/Ganeti/Query/Language.hs           |   4 +-
test/hs/Test/Ganeti/Rpc.hs                      |   4 +-
test/hs/Test/Ganeti/SlotMap.hs                  |   5 +-
test/hs/Test/Ganeti/Storage/Diskstats/Parser.hs |   4 +-
test/hs/Test/Ganeti/Storage/Lvm/LVParser.hs     |   4 +-
test/hs/Test/Ganeti/TestCommon.hs               |   6 +-
test/hs/Test/Ganeti/TestHelper.hs               |   4 +-
test/hs/Test/Ganeti/Types.hs                    |   4 +-
test/hs/Test/Ganeti/Utils.hs                    |   8 +-
test/hs/Test/Ganeti/Utils/MultiMap.hs           |   4 +-
test/hs/Test/Ganeti/WConfd/TempRes.hs           |   3 +-
test/hs/htest.hs                                |   4 +-
98 files changed, 701 insertions(+), 258 deletions(-)
create mode 100644 src/Ganeti/Prelude.hs

--
2.5.0.457.gab17608

Reply via email to