On Wed, Sep 09, 2015 at 12:10:28PM +0200, 'Bhimanavajjula Aditya' via
ganeti-devel wrote:
As the implicit definition requires ResultStatus
to be a Generic instance
Signed-off-by: Bhimanavajjula Aditya <[email protected]>
---
src/Ganeti/Query/Language.hs | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/Ganeti/Query/Language.hs b/src/Ganeti/Query/Language.hs
index 882a9da..4b85ee7 100644
--- a/src/Ganeti/Query/Language.hs
+++ b/src/Ganeti/Query/Language.hs
@@ -94,7 +94,8 @@ $(makeJSONInstance ''ResultStatus)
-- | No-op 'NFData' instance for 'ResultStatus', since it's a single
-- constructor data-type.
-instance NFData ResultStatus
+instance NFData ResultStatus where
+ rnf x = seq x ()
-- | Check that ResultStatus is success or fail with descriptive
-- message.
--
2.6.0.rc0.131.gf624c3d
Just a minor point, it'd be better to name the commit like "... NFData
instance of ResultStatus" so that it's more descriptive.
Rest LGTM, thanks
