LGTM, thanks.

On Tue, Sep 29, 2015 at 5:21 PM, 'Hrvoje Ribicic' via ganeti-devel <
[email protected]> wrote:

> The QA previously took in the entire certificate file, along with the
> private key. As this is really not necessary, change it to be more
> conservative.
>
> Signed-off-by: Hrvoje Ribicic <[email protected]>
> ---
>  qa/qa_rapi.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qa/qa_rapi.py b/qa/qa_rapi.py
> index 1c43e7a..807383e 100644
> --- a/qa/qa_rapi.py
> +++ b/qa/qa_rapi.py
> @@ -132,7 +132,8 @@ def ReloadCertificates(ensure_presence=True):
>    master = qa_config.GetMasterNode()
>
>    # Load RAPI certificate from master node
> -  cmd = ["cat", qa_utils.MakeNodePath(master, pathutils.RAPI_CERT_FILE)]
> +  cmd = ["openssl", "x509", "-in",
> +         qa_utils.MakeNodePath(master, pathutils.RAPI_CERT_FILE)]
>
>    # Write to temporary file
>    _rapi_ca = tempfile.NamedTemporaryFile()
> --
> 2.6.0.rc2.230.g3dd15c0
>
>


-- 
Lisa Velden
Software Engineer
[email protected]

Google Germany GmbH
Dienerstraße 12
80331 München

Geschäftsführer: Graham Law, Christine Elizabeth Flores
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Reply via email to