On Tue, Sep 29, 2015 at 5:21 PM, 'Hrvoje Ribicic' via ganeti-devel <
[email protected]> wrote:

> When a cluster is not to be created, the QA assumes that any nodes
> listed in the QA definition file are actually there. It only makes
> sense not to remove them from the cluster once the testing has been
> completed, unless this was implicitly requested with the
> "cluster-destroy" flag.
>

Was this supposed to be "It only makes sense to remove"? Otherwise the
sentence is a bit confusing.


>
> Signed-off-by: Hrvoje Ribicic <[email protected]>
> ---
>  qa/ganeti-qa.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qa/ganeti-qa.py b/qa/ganeti-qa.py
> index 92ab27f..9c8a058 100755
> --- a/qa/ganeti-qa.py
> +++ b/qa/ganeti-qa.py
> @@ -1049,7 +1049,7 @@ def RunQa():
>
>    RunPerformanceTests()
>
> -  RunTestIf("create-cluster", qa_node.TestNodeRemoveAll)
> +  RunTestIf("cluster-destroy", qa_node.TestNodeRemoveAll)
>
>    RunTestIf("cluster-destroy", qa_cluster.TestClusterDestroy)
>
> --
> 2.6.0.rc2.230.g3dd15c0
>
>


-- 
Lisa Velden
Software Engineer
[email protected]

Google Germany GmbH
Dienerstraße 12
80331 München

Geschäftsführer: Graham Law, Christine Elizabeth Flores
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Reply via email to