On Tue, Oct 13, 2015 at 02:44:31PM +0000, Helga Velroyen wrote: > On Tue, 13 Oct 2015 at 16:41 'Klaus Aehlig' via ganeti-devel < > [email protected]> wrote: > > > On Tue, Oct 13, 2015 at 11:28:55AM +0000, Helga Velroyen wrote: > > > Hi! > > > > > > On Tue, 13 Oct 2015 at 10:49 'Klaus Aehlig' via ganeti-devel < > > > [email protected]> wrote: > > > > > > > Signed-off-by: Klaus Aehlig <[email protected]> > > > > --- > > > > src/Ganeti/Constants.hs | 3 +++ > > > > 1 file changed, 3 insertions(+) > > > > > > > > diff --git a/src/Ganeti/Constants.hs b/src/Ganeti/Constants.hs > > > > index d8a8a7d..34272dd 100644 > > > > --- a/src/Ganeti/Constants.hs > > > > +++ b/src/Ganeti/Constants.hs > > > > @@ -5415,6 +5415,9 @@ dataCollectorDrbd = "drbd" > > > > dataCollectorLv :: String > > > > dataCollectorLv = "lv" > > > > > > > > +dataCollectorKvmRSS :: String > > > > +dataCollectorKvmRSS = "kvm-inst-rss" > > > > > > > > > > Mind adding a comment what RSS is? My first thought was 'like RSS feed"? > > > > What about the following interdiff? > > > > commit cf334da0de967e345879b4855faa64d3b51ee42c > > Author: Klaus Aehlig <[email protected]> > > Date: Tue Oct 13 16:40:41 2015 +0200 > > > > Interdiff [PATCH master 2/4] Declare name for KVM instance RSS > > collector > > > > diff --git a/src/Ganeti/Constants.hs b/src/Ganeti/Constants.hs > > index 2e7e7ac..14e7c50 100644 > > --- a/src/Ganeti/Constants.hs > > +++ b/src/Ganeti/Constants.hs > > @@ -5415,6 +5415,7 @@ dataCollectorDrbd = "drbd" > > dataCollectorLv :: String > > dataCollectorLv = "lv" > > > > +-- | Collector for the resident set size of kvm processes. > > dataCollectorKvmRSS :: String > > dataCollectorKvmRSS = "kvm-inst-rss" > > > > that explains the acronym, but does not tell me what a resident set size > is. I think it would be worth adding a line about that.
So what about this interdiff instead? commit 7668994495f7a34fb84f6fec9e82e4be5eb4f404 Author: Klaus Aehlig <[email protected]> Date: Tue Oct 13 16:40:41 2015 +0200 Interdiff [PATCH master 2/4] Declare name for KVM instance RSS collector diff --git a/src/Ganeti/Constants.hs b/src/Ganeti/Constants.hs index 2e7e7ac..07f4117 100644 --- a/src/Ganeti/Constants.hs +++ b/src/Ganeti/Constants.hs @@ -5415,6 +5415,8 @@ dataCollectorDrbd = "drbd" dataCollectorLv :: String dataCollectorLv = "lv" +-- | Collector for the resident set size of kvm processes, i.e., +-- the number of pages the kvm process has in RAM. dataCollectorKvmRSS :: String dataCollectorKvmRSS = "kvm-inst-rss" -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Matthew Scott Sucherman, Paul Terence Manicle
