LGTM, thanks On Tue, Oct 13, 2015, 5:14 PM 'Klaus Aehlig' via ganeti-devel < [email protected]> wrote:
> > suggested interdiff > > commit 12e7ff053cd6c045be83c68967afa9194ad46b66 > Author: Klaus Aehlig <[email protected]> > Date: Tue Oct 13 17:13:46 2015 +0200 > > Interdiff [PATCH master 3/4] Add data collector for kvm instances RSS > > diff --git a/src/Ganeti/DataCollectors/KvmRSS.hs > b/src/Ganeti/DataCollectors/KvmRSS.hs > index 486d273..3f26617 100644 > --- a/src/Ganeti/DataCollectors/KvmRSS.hs > +++ b/src/Ganeti/DataCollectors/KvmRSS.hs > @@ -1,5 +1,10 @@ > {-| kvm resident set size collector > > +It collects the resident set size (RSS) for all kvm > +processes managed by Ganeti, i.e., the number of pages > +the process has in RAM. The value is obtained > +by taking the corresponding value from /proc/$pid/memstat. > + > -} > > {- > @@ -56,7 +61,7 @@ import Ganeti.DataCollectors.Types > import Ganeti.Objects > import Ganeti.Path (kvmPidDir) > > --- | The name of this data collector. > +-- | The name of this data collector for the resident set size (RSS). > dcName :: String > dcName = C.dataCollectorKvmRSS > > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Matthew Scott Sucherman, Paul Terence Manicle > -- Helga Velroyen Software Engineer [email protected] Google Germany GmbH Dienerstraße 12 80331 München Geschäftsführer: Graham Law, Christine Elizabeth Flores Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks.
