LGTM, but I still have two remarks:

On 11/20/2015 01:42 PM, 'Helga Velroyen' via ganeti-devel wrote:

backend.py

--    logging.debug("Add ssh key of node '%s'.", node_name)

Why did you decide to remove the logging.debug call?

Disk.hs

++      addInst i = csConfigDataL . configInstancesL
++                  . alterContainerL (UTF8.fromString $ uuidOf inst)
++                    .~ Just i

From my point of view, it's better to preserver (... $ uuidOf i) instead. It doesn't affect the current functionality but can prevent misunderstands in the future.

Reply via email to