On Fri, 20 Nov 2015 at 14:00 Oleg Ponomarev <[email protected]> wrote:
> LGTM, but I still have two remarks:
>
> On 11/20/2015 01:42 PM, 'Helga Velroyen' via ganeti-devel wrote:
>
> backend.py
>
> > -- logging.debug("Add ssh key of node '%s'.", node_name)
>
> Why did you decide to remove the logging.debug call?
>
Because with the refactoring it is not actually added there anymore (but as
a bulk at the end). I'd rather send another patch later to add a proper
message there than keeping the obsolete one here.
>
> Disk.hs
>
> > ++ addInst i = csConfigDataL . configInstancesL
> > ++ . alterContainerL (UTF8.fromString $ uuidOf inst)
> > ++ .~ Just i
>
> From my point of view, it's better to preserver (... $ uuidOf i)
> instead. It doesn't affect the current functionality but can prevent
> misunderstands in the future.
>
Actually, I seem to have sent the wrong version of this. I'll resend it
soon, but no need for you to review it. Riba was doing that already.
Thanks,
Helga
--
Helga Velroyen
Software Engineer
[email protected]
Google Germany GmbH
Dienerstraße 12
80331 München
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und
löschen Sie die E-Mail und alle Anhänge. Vielen Dank.
This e-mail is confidential. If you are not the right addressee please do
not forward it, please inform the sender, and please erase this e-mail
including any attachments. Thanks.
