On 11/25/2015 04:20 PM, Hrvoje Ribicic wrote:
General remarks:
Consider adding another node to the mix - the QA is missing checks for
global hooks running on both master and other nodes, and running on
master despite not being executed on other nodes. You can allow the
LUTestDelay to run hooks to achieve that effect - it can be run on
arbitrary nodes, and being a test opcode can be modified as you wish.
Alternatively, unit test these cases? The main benefit of the QA is
that we get to see how global hooks work with real files, and more
complicated cases can be unit tested.
It's better to cover the rest cases by unit tests. I'll implement them
and send back soon.
As for now, please check the remastered qa tests.
