On 21 June 2016 at 16:29, Brian Foley <bpfo...@google.com> wrote: > On Sat, Jun 18, 2016 at 04:54:51AM +0200, Iustin Pop wrote: > > From: Iustin Pop <ius...@google.com> > > > > My previous pylint cleanups were done without psutil installed; as soon > > I installed it, pylint showed that the wheezy's version of psutil is too > > old (0.5.1), not having the cpu_count() function which was introduced in > > 2.0.0. Furthermore, thanks to Brian, it turns out that too new versions > > are also unsupported. > > > > This change adds a simple way to detect this and to degrade gracefully > > by throwing an appropriate exception instead of an unclear one at > > runtime. Tested with wheezy's 0.5.0 and sid's 4.1.1 versions. It also > > updates the INSTALL file to note the supported versions and that > > [2.0.0,2.2.0) had issues with FH leaks. > > > > Signed-off-by: Iustin Pop <ius...@google.com> > > LGTM, and sorry for the delay in reviewing. >
No worries, thanks!