On 21 June 2016 at 16:28, Brian Foley <[email protected]> wrote: > On Sat, Jun 18, 2016 at 04:53:25AM +0200, Iustin Pop wrote: > > On 2016-06-15 10:23:57, Brian Foley wrote: > > > Additionally, 0.5.0 had a psutil.Process.{get,set}_cpu_affinity() API, > > > which we use in the kvm code. In 2.0.0 API was renamed to > cpu_affinity() > > > and the old API deprecated, and in 3.0 the old {get,set} API was > removed. > > > > > > So we currently need to restrict psutils to 2.x, but maybe it's just > > > easier to add an __attr__ check for the new affinity API, but perhaps > > > this should be done in a separate patch. > > > > Just to see if I understand: we don't support 3.x+ due to the > > cpu_affinity API only? > > I think so yes. That's the only thing I saw when I looked through the > psutil > version history a few months ago. > > Thinking a little more about what I wrote above, since we require psutil > >= 2.0 > for kvm anyway, then it would be perfectly fine to replace the use of the > 0.5.0 > affinity API in the kvm code with the >= 2.0 API. I don't know if this on > its > own would be sufficient to get it to work with psutil >= 3.0, but it would > be > a step in the right direction. We can look at this another time though. >
Yes, that's why I asked—it was kind of surprising to see the use of 0.5.0 API but not actually supporting 0.5.0 :) thanks, iustin
